Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tabs in websearch prompt #754

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Remove tabs in websearch prompt #754

merged 1 commit into from
Jan 30, 2024

Conversation

nsarrazin
Copy link
Collaborator

The websearch prompt injected extra tabs because of the multi-line string 😅

@nsarrazin nsarrazin added bug Something isn't working websearch labels Jan 30, 2024
@nsarrazin nsarrazin requested a review from mishig25 January 30, 2024 13:37
mishig25
mishig25 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@nsarrazin nsarrazin merged commit dc86148 into main Jan 30, 2024
3 checks passed
@nsarrazin nsarrazin deleted the fix/websearch_tabs branch January 30, 2024 13:41
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
@nsarrazin
Remove tabs in websearch prompt (huggingface#754)
5b6096e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishig25 mishig25 mishig25 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working websearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsarrazin @mishig25