Convert all assistants avatar to jpeg server-side #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
added
enhancement
mishig25
reviewed
Feb 2, 2024
mishig25
reviewed
Feb 2, 2024
Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* Convert all assistants to jpeg server side, and rename endpoint appropriately * Improve avatar validation/error display * preserve aspect ratio on resize * Update src/lib/components/chat/ChatMessages.svelte Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu> --------- Co-authored-by: Mishig <mishig.davaadorj@coloradocollege.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all avatars to jpeg server side and resize them to fit in a 512px thumbnail. We already had the dependency for thumbnail generation so why not here too!
I also renamed the route
/avatarto/avatar.jpg, hopefully this will get picked up by our asset caching