[Assistants] Add pagination #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
force-pushed
the
assistnats_pagination
branch
from
fec5d55 to
d5ee312
Compare
mishig25
force-pushed
the
assistnats_pagination
branch
from
d5ee312 to
cc012bb
Compare
mishig25
commented
Feb 4, 2024
| @@ -3,20 +3,36 @@ import { ENABLE_ASSISTANTS } from "$env/static/private"; | |||
| import { collections } from "$lib/server/database.js"; | |||
| import type { Assistant } from "$lib/types/Assistant"; | |||
| import { redirect } from "@sveltejs/kit"; | |||
| import type { Filter } from "mongodb"; | |||
|
|
|||
| const NUM_PER_PAGE = 10; | |||
There was a problem hiding this comment.
@gary149 change this number to what's appropriate
gary149
approved these changes
Feb 4, 2024
| export let isDisabled = false; | ||
| </script> | ||
|
|
||
| <button |
There was a problem hiding this comment.
This should be a link <a> to prev/next page (vs button with click event)
There was a problem hiding this comment.
handled in 53ed09b
src/lib/components/Pagination.svelte
Outdated
|
|
||
| const numTotalPages = Math.ceil(numTotalItems / numItemsPerPage); | ||
|
|
||
| $: { |
There was a problem hiding this comment.
This seems a bit complex 👀
There was a problem hiding this comment.
copied from hub. I will see what should be done for simplification
There was a problem hiding this comment.
handled in 914dbd9
src/lib/components/Pagination.svelte
Outdated
| <PaginationArrow | ||
| direction="previous" | ||
| isDisabled={pageIndex - 1 < 0} | ||
| onClick={handleClickDirection} |
There was a problem hiding this comment.
no need for javascript, next/before should be links
There was a problem hiding this comment.
handled in 53ed09b
src/routes/assistants/+page.svelte
Outdated
Comment on lines
30
to
34
| const onPaginationChange = (newPageIndex: number) => { | ||
| pageIndex = newPageIndex; | ||
| const newUrl = new URL($page.url); | ||
| newUrl.searchParams.set("p", newPageIndex.toString()); | ||
| goto(newUrl); |
There was a problem hiding this comment.
handled in 53ed09b
Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
gary149
reviewed
Feb 5, 2024
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* [Assistants] Add pagination * Update src/lib/components/PaginationArrow.svelte Co-authored-by: Victor Muštar <victor.mustar@gmail.com> * format * Simplify by using a href * this statement needs to be reactive * simplify pagination * update disabled * Update src/routes/assistants/+page.server.ts --------- Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pagination to assistants page