-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datasets 2.14.3 #1614
Update datasets 2.14.3 #1614
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## update-datasets-2.14 #1614 +/- ##
=======================================================
Coverage ? 88.33%
=======================================================
Files ? 131
Lines ? 7344
Branches ? 0
=======================================================
Hits ? 6487
Misses ? 857
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Note that with 2.14.3 patch release (concretely, huggingface/datasets#6107), we no longer have
Number of errors from 40 to 37. |
I would suggest merging this PR into the branch: And then adding the fixes in separate PRs to that branch, until the CI is green in that branch. Do you agree, @huggingface/datasets-server? |
yes, good methodology. this upgrade seems to be hard :) |
Yes, quite hard... Lots of different fixes are required... I prefer to do them separately, so that we can in the future refactor them individually and port them to |
* Update datasets dep version to 2.14.3 * Update poetry lock files
* Update datasets dep version to 2.14.3 * Update poetry lock files
Update
datasets
dependency to version 2.14.3, instead of 2.14.1 because there were issues. See:We are merging this PR into a dedicated branch:
This way we can merge subsequent required PRs into the same branch to fix the CI. Once the CI is green, we can merge the branch into main
Fix partially #1589.
Fix partially #1550.
Supersede and close #1577.
Supersede and close #1588.