Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets 2.14.3 #1614

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Aug 3, 2023

Update datasets dependency to version 2.14.3, instead of 2.14.1 because there were issues. See:

We are merging this PR into a dedicated branch:

This way we can merge subsequent required PRs into the same branch to fix the CI. Once the CI is green, we can merge the branch into main

Fix partially #1589.
Fix partially #1550.

Supersede and close #1577.
Supersede and close #1588.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (update-datasets-2.14@128d703). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             update-datasets-2.14    #1614   +/-   ##
=======================================================
  Coverage                        ?   88.33%           
=======================================================
  Files                           ?      131           
  Lines                           ?     7344           
  Branches                        ?        0           
=======================================================
  Hits                            ?     6487           
  Misses                          ?      857           
  Partials                        ?        0           
Flag Coverage Δ
jobs_cache_maintenance 99.08% <0.00%> (?)
jobs_mongodb_migration 85.07% <0.00%> (?)
libs_libapi 85.54% <0.00%> (?)
libs_libcommon 91.53% <0.00%> (?)
services_admin 85.87% <0.00%> (?)
services_api 88.13% <0.00%> (?)
services_rows 82.93% <0.00%> (?)
services_search 78.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertvillanova
Copy link
Member Author

albertvillanova commented Aug 3, 2023

Note that with 2.14.3 patch release (concretely, huggingface/datasets#6107), we no longer have

TypeError: get_authentication_headers_for_url() got an unexpected keyword argument 'use_auth_token'

Number of errors from 40 to 37.

@albertvillanova
Copy link
Member Author

I would suggest merging this PR into the branch:

And then adding the fixes in separate PRs to that branch, until the CI is green in that branch.

Do you agree, @huggingface/datasets-server?

@severo
Copy link
Collaborator

severo commented Aug 3, 2023

yes, good methodology. this upgrade seems to be hard :)

@albertvillanova
Copy link
Member Author

Yes, quite hard... Lots of different fixes are required... I prefer to do them separately, so that we can in the future refactor them individually and port them to datasets public API.

@albertvillanova albertvillanova merged commit 4439b86 into update-datasets-2.14 Aug 3, 2023
@albertvillanova albertvillanova deleted the update-datasets-2.14.3 branch August 3, 2023 16:18
albertvillanova added a commit that referenced this pull request Aug 4, 2023
* Update datasets dep version to 2.14.3

* Update poetry lock files
albertvillanova added a commit that referenced this pull request Aug 4, 2023
* Update datasets dep version to 2.14.3

* Update poetry lock files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants