Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment between card tag validation and docs #4829

Open
albertvillanova opened this issue Aug 11, 2022 · 2 comments
Open

Misalignment between card tag validation and docs #4829

albertvillanova opened this issue Aug 11, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@albertvillanova
Copy link
Member

albertvillanova commented Aug 11, 2022

Describe the bug

As pointed out in other issue: #4827 (comment)
the validation of the dataset card tags is not aligned with its documentation: e.g.

  • implementation: license: List[str]
  • docs: license: Union[str, List[str]]

They should be aligned.

CC: @julien-c

@albertvillanova albertvillanova added the bug Something isn't working label Aug 11, 2022
@julien-c
Copy link
Member

(Note that the doc is aligned with the hub validation rules, and the "ground truth" is the hub validation rules given that they apply to all datasets, not just the canonical ones)

@mariosasko
Copy link
Collaborator

Instead of our own implementation, we now use huggingface_hub's DatasetCardData, which has the correct type hint, so I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants