Add license metadata to pg19 #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
approved these changes
Aug 11, 2022
|
The documentation is not available anymore as the PR was closed or merged. |
albertvillanova
requested changes
Aug 11, 2022
datasets/pg19/README.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| language: | |||
| - en | |||
| license: apache-2.0 | |||
There was a problem hiding this comment.
The license tag should be an array.
There was a problem hiding this comment.
hmm that's not what's documented on https://huggingface.co/docs/hub/datasets-cards =)
There was a problem hiding this comment.
but ok i'll push this for consistency
There was a problem hiding this comment.
Good catch: we should align docs and validation implementation:
datasets/src/datasets/utils/metadata.py
Line 232 in cfae8ac
Co-Authored-By: Roy Rijkers <royrijkers@live.nl>
albertvillanova
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported over email by Roy Rijkers