Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SILICONE benchmark #1761

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Add SILICONE benchmark #1761

merged 3 commits into from
Jan 26, 2021

Conversation

eusip
Copy link
Contributor

@eusip eusip commented Jan 21, 2021

My collaborators and I within the Affective Computing team at Telecom Paris would like to re-submit our spoken dialogue dataset for publication.

This is a new pull request relative to the previously closed request which was reviewed by @lhoestq.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the resubmission ! And for the changes in the the tags

I left a few comments.

Also no need to git rebase since it can mess up the github diff ;)

silicone/README.md Show resolved Hide resolved
silicone/README.md Outdated Show resolved Hide resolved
silicone/README.md Outdated Show resolved Hide resolved
silicone/README.md Outdated Show resolved Hide resolved
silicone/README.md Outdated Show resolved Hide resolved
silicone/silicone.py Outdated Show resolved Hide resolved
Merge remote-tracking branch 'upstream/master' into silicone-benchmark
@eusip
Copy link
Contributor Author

eusip commented Jan 26, 2021

Thanks for the feedback. All your comments have been addressed!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

Looks all good now :)

@lhoestq lhoestq merged commit 0dd0879 into huggingface:master Jan 26, 2021
@eusip
Copy link
Contributor Author

eusip commented Jan 27, 2021

Thank you for your constructive feedback! I now know how to best format future datasets that our team plans to publish in the near future :)

@lhoestq
Copy link
Member

lhoestq commented Jan 27, 2021

Awesome ! Looking forward to it :)

@eusip
Copy link
Contributor Author

eusip commented Jan 29, 2021

Hi @lhoestq ! One last question. Our research team would like to distribute a link to this dataset amongst the spoken dialogue research community but the dataset does not show in the dropdown menu at huggingface.co. Is there anything else we must do in order to find the dataset there ?

Once the dataset does show in the dropdown menu, how can I affiliate it with the Telecom Paris organization that I already created at the website ?

@lhoestq lhoestq changed the title Initial commit including HF-recommended code revisions Add SILICONE benchmark Jan 29, 2021
@lhoestq
Copy link
Member

lhoestq commented Jan 29, 2021

The files are not located in the right place in the repo. Let me move them

@lhoestq lhoestq mentioned this pull request Jan 29, 2021
@lhoestq
Copy link
Member

lhoestq commented Jan 29, 2021

I created a PR at #1794

@lhoestq
Copy link
Member

lhoestq commented Jan 29, 2021

I just merged the change @eusip, now the dataset page is available at the url:
https://huggingface.co/datasets/silicone

@eusip
Copy link
Contributor Author

eusip commented Feb 4, 2021

Thank you for moving the folder for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants