Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newspop dataset #1871

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Conversation

frankier
Copy link
Contributor

No description provided.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for adding this one

datasets/newspop/README.md Outdated Show resolved Hide resolved
datasets/newspop/README.md Outdated Show resolved Hide resolved
datasets/newspop/README.md Show resolved Hide resolved
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just a few things to rename:

datasets/newspop/newspop.py Outdated Show resolved Hide resolved
datasets/newspop/dataset_infos.json Outdated Show resolved Hide resolved
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@frankier frankier requested a review from lhoestq March 5, 2021 11:25
@lhoestq
Copy link
Member

lhoestq commented Mar 8, 2021

Thanks for the changes :)
merging

@lhoestq lhoestq merged commit ffeccc6 into huggingface:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants