-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for the addition of TIMIT dataset #1903
Conversation
@patrickvonplaten could you please review and help me close this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for adding this one !
This is pretty good overall, good job :)
I left a few comments
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
…atasets into add-timit-dataset
@lhoestq Thank you so much for your comments and for patiently reviewing the code. Have hopefully included all the suggested changes. Let me know if any more changes are required. Sorry the code had lots of silly errors from my side!:' Will be more careful from next time! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes ! :)
added my last comments
Also it looks like the dummy data file is quite big (5MB), could you try to reduce its size a bit ?
To do so feel free to only keep 1 or 2 lines in the csv files (with is audio to TRUE and is_converted_audio to FALSE) and only keep the relevant wav/txt/phn files.
The idea is to have a very small set of data in order to test the script quickly and keeping the repository lightweight :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes ! :)
Below points needs to be addressed:
Also the links (except the download) point to the ami corpus! ;-)
@patrickvonplaten Requesting your comments, will be happy to address them!