Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrowWriter closes stream at exit #1971

Merged
merged 17 commits into from
Mar 10, 2021
Merged

Fix ArrowWriter closes stream at exit #1971

merged 17 commits into from
Mar 10, 2021

Commits on Mar 2, 2021

  1. Test ArrowWriter closes stream at exit

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    49d14fb View commit details
    Browse the repository at this point in the history

  2. Implement ArrowWriter as context manager and close stream at exit

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d3c0e0b View commit details
    Browse the repository at this point in the history

  3. Specify exception class

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    19cd459 View commit details
    Browse the repository at this point in the history

  4. Use ArrowWriter as context manager

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    b28967f View commit details
    Browse the repository at this point in the history

  5. Fix ArrowWriter.close

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8c230ee View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into fix-arrow-writer

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4d50e95 View commit details
    Browse the repository at this point in the history

  7. Fix ArrowWriter.close

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2a7a861 View commit details
    Browse the repository at this point in the history

  8. Test stream already closed at ArrowWriter context exit

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5c7af22 View commit details
    Browse the repository at this point in the history

  9. Revert "Use ArrowWriter as context manager" 

    This reverts commit b28967f.
    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ba368f5 View commit details
    Browse the repository at this point in the history

  10. Use ArrowWriter as context manager in tests

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d2e123d View commit details
    Browse the repository at this point in the history

  11. Generalize Exception type in ArrowWriter.close

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    84ad7f3 View commit details
    Browse the repository at this point in the history

  12. Use ArrowWriter as context manager in benchmarks

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    c521ffe View commit details
    Browse the repository at this point in the history

  13. Use ArrowWriter as context manager in arrow_writer and builder

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7d241ce View commit details
    Browse the repository at this point in the history

  14. Use ArrowWriter as context manager in arrow_dataset

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e00d72a View commit details
    Browse the repository at this point in the history

  15. Use ArrowWriter as context manager in metric

    @albertvillanova
    albertvillanova committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7f287fb View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Revert "Use ArrowWriter as context manager in metric" 

    This reverts commit 7f287fb.
    @albertvillanova
    albertvillanova committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    10d9258 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Merge remote-tracking branch 'upstream/master' into fix-arrow-writer

    @albertvillanova
    albertvillanova committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    6f1a701 View commit details
    Browse the repository at this point in the history