-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bAbI QA tasks #2053
Add bAbI QA tasks #2053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive one ! good job
Hi @lhoestq, Should I remove the 160 configurations? Is it too much? EDIT: |
Thanks for the changes !
Yea 160 configuration is a lot.
for example, and with a list of the possible combinations.
It looks appropriate, thanks :) |
Hi @lhoestq I'm unable to test it locally using: load_dataset("datasets/babi_qa", type="hn", task_no="qa1") It raises an error: TypeError: __init__() got an unexpected keyword argument 'type' Will this be possible only after merging? Or am I missing something here? |
Can you try adding this class attribute to BUILDER_CONFIG_CLASS = BabiQaConfig This should fix the TypeError issue you got |
My bad. Thanks a lot! |
Hi @lhoestq I have added the changes. Only the "qa1" task for each category is included. Also, I haven't removed the size categories and other description because I think it will still be useful. I have updated the line in README showing the example. Thanks, |
Hi @lhoestq, Does this look good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !!
bAbI
project by Facebook Research.Note: I have currently added all the 160 configs. If this seems impractical, I can keep only a few. While each
dummy_data.zip
weighs a few KBs, overall it is around 1.3MB for all configurations. This is problematic. Let me know what is to be done.Thanks :)
Checkbox
/datasets/my_dataset/my_dataset.py
using the template_DESCRIPTION
and_CITATION
variables_infos()
,_split_generators()
and_generate_examples()
BUILDER_CONFIGS
class attribute is filled with the different configurations of the dataset and that theBUILDER_CONFIG_CLASS
is specified if there is a custom config class.dataset_infos.json
for all configurationsdummy_data.zip
files to have the dataset script tested and that they don't weigh too much (<50KB)README.md
using the template : fill the tags and the various paragraphs