Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes check of TF_AVAILABLE and TORCH_AVAILABLE #2073

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Fixes check of TF_AVAILABLE and TORCH_AVAILABLE #2073

merged 5 commits into from
Mar 18, 2021

Conversation

philschmid
Copy link
Member

What is this PR doing

This PR implements the checks if Tensorflow and Pytorch are available the same way as transformers does it. I added the additional checks for the different Tensorflow and torch versions. #2068

@philschmid philschmid requested a review from lhoestq March 17, 2021 21:28
@philschmid philschmid changed the title Fixes definition of TF_AVAILABLE and TORCH_AVAILABLE Fixes check of TF_AVAILABLE and TORCH_AVAILABLE Mar 17, 2021
lhoestq
lhoestq approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

src/datasets/config.py Outdated Show resolved Hide resolved
@philschmid philschmid merged commit b987f65 into master Mar 18, 2021
@philschmid philschmid deleted the fix-importlib-tensorflow branch March 18, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philschmid @lhoestq