Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated user permissions based on umask #2157

Merged
merged 3 commits into from
Apr 6, 2021
Merged

updated user permissions based on umask #2157

merged 3 commits into from
Apr 6, 2021

Conversation

bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented Mar 31, 2021

Updated user permissions based on running user's umask (#2065). Let me know if 0o666 is looking good or should I change it to ~umask only (to give execute permissions as well)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
I noticed that you didn't set the umask back to its original value and added a comment about that. I also mentioned a potential security issue that we can avoid

src/datasets/arrow_dataset.py Outdated Show resolved Hide resolved
src/datasets/arrow_dataset.py Outdated Show resolved Hide resolved
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants