Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matthews/Pearson/Spearman correlation metrics #2328

Merged
merged 4 commits into from
May 6, 2021
Merged

Add Matthews/Pearson/Spearman correlation metrics #2328

merged 4 commits into from
May 6, 2021

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented May 6, 2021 •
edited
Loading

Added three metrics:

  • The Matthews correlation coefficient (from sklearn)
  • The Pearson correlation coefficient (from scipy)
  • The Spearman correlation coefficient (from scipy)

cc @sgugger

sgugger
sgugger approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for adding those!

metrics/matthews_correlation/matthews_correlation.py Outdated Show resolved Hide resolved
metrics/pearsonr/pearsonr.py Outdated Show resolved Hide resolved
metrics/spearmanr/spearmanr.py Outdated Show resolved Hide resolved
@lhoestq @sgugger
Apply suggestions from code review
9aee070 
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@lhoestq lhoestq merged commit 2451dd6 into master May 6, 2021
@lhoestq lhoestq deleted the more-metrics branch May 6, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhoestq @sgugger