Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getchildren from hyperpartisan news detection #2367

Merged

Conversation

ghomasHudson
Copy link
Contributor

@ghomasHudson ghomasHudson commented May 17, 2021

Element.getchildren() is now deprecated in the ElementTree library (I think in python 3.9, so it still passes the automated tests which are using 3.6. But for those of us on bleeding-edge distros it now fails).

https://bugs.python.org/issue29209

@ghomasHudson ghomasHudson changed the title Remove getchildren Remove getchildren from hyperpartisan news detection May 17, 2021
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@lhoestq lhoestq merged commit 1f3e361 into huggingface:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants