Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HendrycksTest dataset #2370

Merged
merged 10 commits into from
May 31, 2021
Merged

Adding HendrycksTest dataset #2370

merged 10 commits into from
May 31, 2021

Conversation

andyzoujm
Copy link
Contributor

@andyzoujm andyzoujm commented May 17, 2021

Adding Hendrycks test from https://arxiv.org/abs/2009.03300.
I'm having a bit of trouble with dummy data creation because some lines in the csv files aren't being loaded properly (only the first entry loaded in a row of length 6). The dataset is loading just fine. Hope you can kindly help!
Thank you!

@andyzoujm andyzoujm changed the title Hendrycks test Adding HendrycksTest dataset May 18, 2021
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this dataset !

The dataset python script looks very good, thanks :)
I added a few comments in the dataset card

I also noticed that the dummy data zip files were quite big (160KB each). Could to try to reduce their sizes please ? For example feel free to take a look inside the abstract_algebra dummy data zip file and remove all the csv files that are unrelated to abstract_algebra:

  • formal_logic_val.csv
  • prehistory_val.csv
  • etc
    If you could do that for all subjects that would be perfect :) Feel free to use a script to automate that of course. Thank you !

datasets/hendrycks_test/README.md Outdated Show resolved Hide resolved
datasets/hendrycks_test/README.md Outdated Show resolved Hide resolved
datasets/hendrycks_test/README.md Outdated Show resolved Hide resolved
datasets/hendrycks_test/README.md Outdated Show resolved Hide resolved
datasets/hendrycks_test/README.md Show resolved Hide resolved
datasets/hendrycks_test/README.md Show resolved Hide resolved
datasets/hendrycks_test/hendrycks_test.py Outdated Show resolved Hide resolved
datasets/hendrycks_test/hendrycks_test.py Outdated Show resolved Hide resolved
datasets/hendrycks_test/hendrycks_test.py Outdated Show resolved Hide resolved
@andyzoujm
Copy link
Contributor Author

@lhoestq Thank you for the review. I've made the suggested changes. There still might be some problems with dummy data though due to some csv loading issues (which I haven't found the cause to).

@lhoestq
Copy link
Member

lhoestq commented May 31, 2021

I took a look at the dummy data and some csv lines were cropped. I fixed them :)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now ! Thank you so much for adding it :)

@lhoestq lhoestq merged commit 7bac83b into huggingface:master May 31, 2021
@albertvillanova
Copy link
Member

@andyzoujm Any reason why this dataset scrip was called "hendrycks_test" instead of "mmlu"?

We are thinking of renaming it...

@andyzoujm
Copy link
Contributor Author

andyzoujm commented Apr 27, 2023 via email

@albertvillanova
Copy link
Member

Thanks for your reply. Just for the records: we have renamed it to "cais/mmlu": https://huggingface.co/datasets/cais/mmlu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants