Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datasets PEP-561 compliant #2417

Merged
merged 4 commits into from
May 28, 2021
Merged

Make datasets PEP-561 compliant #2417

merged 4 commits into from
May 28, 2021

Conversation

SBrandeis
Copy link
Contributor

Allows to type-check datasets with mypy when imported as a third-party library

PEP-561: https://www.python.org/dev/peps/pep-0561
MyPy doc on the subject: https://mypy.readthedocs.io/en/stable/installed_packages.html

@SBrandeis SBrandeis requested a review from lhoestq May 27, 2021 16:16
lhoestq
lhoestq approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@lhoestq lhoestq merged commit 2aac759 into master May 28, 2021
@lhoestq lhoestq deleted the type-stub branch May 28, 2021 13:09
@julien-c
Copy link
Member

This is super cool, I love that ❤️

@mariosasko mariosasko mentioned this pull request Aug 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SBrandeis @julien-c @lhoestq