Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename QuestionAnswering template to QuestionAnsweringExtractive #2429

Merged
merged 5 commits into from
May 31, 2021
Merged

Rename QuestionAnswering template to QuestionAnsweringExtractive #2429

merged 5 commits into from
May 31, 2021

Conversation

lewtun
Copy link
Member

@lewtun lewtun commented May 31, 2021 •
edited
Loading

Following the discussion with @thomwolf in #2255, this PR renames the QA template to distinguish extractive vs abstractive QA. The abstractive template will be added in a future PR.

@lewtun lewtun requested review from lhoestq and SBrandeis May 31, 2021 10:04
@lewtun lewtun mentioned this pull request May 31, 2021
Merged
lhoestq
lhoestq reviewed May 31, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having "extractive" in the name to make things explicit. However this creates an inconsistency with transformers.

See
https://huggingface.co/transformers/task_summary.html#extractive-question-answering

But this is minor IMO and I'm ok with this renaming

@lewtun
Copy link
Member Author

lewtun commented May 31, 2021

I like having "extractive" in the name to make things explicit. However this creates an inconsistency with transformers.

See
https://huggingface.co/transformers/task_summary.html#extractive-question-answering

But this is minor IMO and I'm ok with this renaming

yes i chose this convention because it allows us to match the QuestionAnsweringXxx naming and i think it's better to have task_name-subtask_name should auto-complete ever become part of the Hub :)

@lewtun lewtun merged commit 5cc895a into huggingface:master May 31, 2021
@lewtun lewtun deleted the refactor-qa-template branch May 31, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

@SBrandeis SBrandeis SBrandeis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewtun @SBrandeis @lhoestq