Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert default in-memory for small datasets #2460

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Revert default in-memory for small datasets #2460

merged 4 commits into from
Jun 8, 2021

Conversation

albertvillanova
Copy link
Member

Close #2458

@albertvillanova albertvillanova added the enhancement New feature or request label Jun 8, 2021
@albertvillanova albertvillanova added this to the 1.8 milestone Jun 8, 2021
lhoestq
lhoestq approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting the default IN_MEMORY_MAX_SIZE to zero and updating the docs :)

@lhoestq lhoestq merged commit a2091a6 into huggingface:master Jun 8, 2021
@stas00
Copy link
Contributor

stas00 commented Jun 8, 2021

Thank you for this welcome change guys!

@stas00 stas00 mentioned this pull request Jun 8, 2021
Closed
This was referenced Jun 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Revert default in-memory for small datasets
3 participants
@albertvillanova @stas00 @lhoestq