Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change udpos features structure #2466

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

cosmeowpawlitan
Copy link
Contributor

@cosmeowpawlitan cosmeowpawlitan commented Jun 9, 2021

The structure is change such that each example is a sentence
The change is done for issues:
#2061
#2444

Close #2061 , close #2444.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the udpos features !

I also fixed the code formatting and regenerated the dataset_infos.json
This looks all good to me :)

To fix the CI we would need to add the yaml tags at the top of the /datasets/xtreme/README.md. Would you be interested in giving it a try ? Otherwise someone can probably add the tags later in another PR

@lhoestq
Copy link
Member

lhoestq commented Jun 16, 2021

Let's add the tags in another PR. Thanks again !

@lhoestq lhoestq merged commit af6e0f6 into huggingface:master Jun 16, 2021
@albertvillanova
Copy link
Member

Close #2061 , close #2444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants