Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs custom stable version #2477

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

albertvillanova
Copy link
Member

Currently docs default version is 1.5.0. This PR fixes this and sets the latest version instead.

@albertvillanova
Copy link
Member Author

I see that @lhoestq overlooked this PR with his commit 07e2b05. 😢

I'm adding a script so that this issue does not happen again.

@albertvillanova
Copy link
Member Author

For the moment, the script only includes update_custom_js, but in a follow-up PR I will include all the required steps to make a package release.

@lhoestq
Copy link
Member

lhoestq commented Jun 11, 2021

I think we just need to clarify the release process in setup.py instead of adding a script that does the replacement

@albertvillanova
Copy link
Member Author

@lhoestq I really think we should implement a script that performs the release (instead of doing it manually as it is done now), as it is already the case in transformers. I will do it in a next PR.

For the moment, this PR includes one of the steps of the release script.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's automate this then :)

@lhoestq lhoestq merged commit 0db3e9a into huggingface:master Jun 14, 2021
@albertvillanova albertvillanova added this to the 1.9 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants