Add docs for to_tf_dataset
#3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
requested review from
albertvillanova,
Rocketknight1,
lhoestq and
mariosasko
lhoestq
reviewed
Oct 29, 2021
Comment on lines
+9
to
+10
| .. image:: /imgs/stream.gif | ||
| :align: center |
Rocketknight1
approved these changes
Oct 29, 2021
|
This looks great, thank you! |
|
Thanks ! For some reason the new GIF is 6MB, which is a bit heavy for an image on a website. The previous one was around 200KB though which is perfect. For a good experience we usually expect images to be less than 500KB - otherwise for users with poor connection it takes too long to load. Could you try to reduce its size ? Than I think we can merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documentation for new features released in v1.13.0, with the main addition being
to_tf_dataset:to_tf_datasetin the tutorial, and moveset_format(type='tensorflow'...)to the Process section (let me know if I'm missing anything @Rocketknight1 😅).IterableDataset.