Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QOL improvements: auto-flatten_indices and desc in map calls #3196

Merged
merged 4 commits into from
Nov 2, 2021
Merged

QOL improvements: auto-flatten_indices and desc in map calls #3196

merged 4 commits into from
Nov 2, 2021

Conversation

mariosasko
Copy link
Collaborator

This PR:

  • automatically calls flatten_indices where needed: in unique and save_to_disk to avoid saving the indices file
  • adds descriptions to the map calls

Fix #3040

lhoestq
lhoestq approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! Thanks also for adding all the desc parameters and improving unique() :)

@lhoestq lhoestq merged commit 172ce96 into master Nov 2, 2021
@lhoestq lhoestq deleted the fix-3040 branch November 2, 2021 15:41
@mariosasko mariosasko mentioned this pull request Nov 24, 2021
Closed
@tianjianjiang tianjianjiang mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mariosasko @lhoestq