Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multidoc2dial Dataset #3205

Merged
merged 11 commits into from
Nov 24, 2021
Merged

Conversation

sivasankalpp
Copy link
Contributor

@sivasankalpp sivasankalpp commented Nov 3, 2021

This PR adds the MultiDoc2Dial dataset introduced in this paper

@sivasankalpp sivasankalpp marked this pull request as ready for review November 3, 2021 21:47
@sivasankalpp
Copy link
Contributor Author

@songfeng cc

@albertvillanova
Copy link
Member

Hi @sivasankalpp, thanks for your PR.

There was a bug in TensorFlow/Keras. We have made a temporary fix in our master branch. Please, merge master into your PR branch, so that the CI tests pass.

git checkout multidoc2dial
git fetch upstream master
git merge upstream/master

@sivasankalpp
Copy link
Contributor Author

Hi @albertvillanova, I have merged master into my PR branch. All tests are passing.
Please take a look when you get a chance, thanks!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome ! Thanks for adding this dataset. And good job with the dataset card and the dataset script :)

I just added some minor comments here and there:

datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Outdated Show resolved Hide resolved
datasets/multidoc2dial/README.md Show resolved Hide resolved
@sivasankalpp
Copy link
Contributor Author

Thanks for your feedback @lhoestq. We addressed your comments in the latest commit. Let us know if everything looks okay :)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks a lot ! LGTM :)

@lhoestq lhoestq merged commit dfa334b into huggingface:master Nov 24, 2021
@sivasankalpp sivasankalpp deleted the multidoc2dial branch November 24, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants