-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multidoc2dial Dataset #3205
Conversation
@songfeng cc |
Hi @sivasankalpp, thanks for your PR. There was a bug in TensorFlow/Keras. We have made a temporary fix in our master branch. Please, merge master into your PR branch, so that the CI tests pass.
|
Hi @albertvillanova, I have merged master into my PR branch. All tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome ! Thanks for adding this dataset. And good job with the dataset card and the dataset script :)
I just added some minor comments here and there:
Thanks for your feedback @lhoestq. We addressed your comments in the latest commit. Let us know if everything looks okay :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks a lot ! LGTM :)
This PR adds the MultiDoc2Dial dataset introduced in this paper