Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to to_tf_dataset documentation #3215

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Small updates to to_tf_dataset documentation #3215

merged 4 commits into from
Nov 4, 2021

Conversation

Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Nov 4, 2021 •
edited
Loading

I added a little more description about to_tf_dataset compared to just setting the format

stevhliu
stevhliu approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, but everything else looks great. Thanks for adding more context around this! 😊

docs/source/use_dataset.rst Outdated Show resolved Hide resolved
docs/source/use_dataset.rst Outdated Show resolved Hide resolved
Rocketknight1 and others added 2 commits November 4, 2021 18:40
@Rocketknight1 @stevhliu
Update docs/source/use_dataset.rst
d03695d 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@Rocketknight1 @stevhliu
Update docs/source/use_dataset.rst
1d6c174 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@Rocketknight1
Copy link
Member Author

@stevhliu Accepted both suggestions, thanks for the review!

@Rocketknight1 Rocketknight1 merged commit c34b2e5 into master Nov 4, 2021
@Rocketknight1 Rocketknight1 deleted the tf_dataset_doc_update branch November 4, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

@lhoestq lhoestq Awaiting requested review from lhoestq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rocketknight1 @stevhliu