-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid PyArrow type optimization if it fails #3234
Conversation
That's good to have a way to disable this easily :) |
@lhoestq Actually, I agree a fallback makes more sense. The current approach is not very practical indeed and would require a mention in the docs. |
Replaced the env variable with a fallback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! I think this could also be part of a documentation page about "Processing text data" in an optimization section cc @stevhliu
Hmm if the fallback automatically happens without the user knowing it, then I don't think we really need to mention it. But if you really wanted to, I think the Improve performance section would be a great place for it! |
Yea I think this could just end up in a note that says that In particular in the "Improve performance" section we mention what users can do to speed up their computations, while this behavior is just some internal feature that users don't have control over anyway. |
Adds a new variable,
DISABLE_PYARROW_TYPES_OPTIMIZATION
, toconfig.py
for easier control of the Arrow type optimization.Fix #2206