Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter method for batched=True #3244

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Fix filter method for batched=True #3244

merged 4 commits into from
Nov 9, 2021

Conversation

thomasw21
Copy link
Contributor

No description provided.

lhoestq
lhoestq reviewed Nov 9, 2021
View reviewed changes
tests/test_arrow_dataset.py Outdated Show resolved Hide resolved
@thomasw21 @lhoestq
Update tests/test_arrow_dataset.py
8f56d5f 
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@thomasw21 thomasw21 changed the title Change the signature of callback fed to filter when batched=True Fix filter for batched=True Nov 9, 2021
@thomasw21 thomasw21 changed the title Fix filter for batched=True Fix filter method for batched=True Nov 9, 2021
lhoestq
lhoestq approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and updating the docs !

@lhoestq lhoestq merged commit 8925d25 into master Nov 9, 2021
@lhoestq lhoestq deleted the thomas/fix_doc_for_batched_filter branch November 9, 2021 15:52
@thomasw21 thomasw21 mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasw21 @lhoestq