Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly converted assert #3323

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

eliasws
Copy link
Contributor

@eliasws eliasws commented Nov 26, 2021

Seems like this assertion was replaced by an exception but the condition got wrongly converted.

Seems like this assertion was replaced by an exception but the condition got wrongly converted.
@eliasws
Copy link
Contributor Author

eliasws commented Nov 26, 2021

Closes #3327

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed thanks !

I also fixed the additional condition

src/datasets/search.py Outdated Show resolved Hide resolved
@lhoestq lhoestq merged commit 5071785 into huggingface:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Shape of query is incorrect, it has to be either a 1D array or 2D (1, N)"
2 participants