Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module inference for archive with a directory #3406

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Fix module inference for archive with a directory #3406

merged 2 commits into from
Dec 8, 2021

Conversation

albertvillanova
Copy link
Member

Fix module inference for an archive file that contains files within a directory.

Fix #3405.

lhoestq
lhoestq approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !! thanks

@lhoestq lhoestq merged commit 50658bb into master Dec 8, 2021
@lhoestq lhoestq deleted the fix-3405 branch December 8, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZIP format inference does not work when files located in a dir inside the archive
2 participants
@albertvillanova @lhoestq