Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max number of data files to infer module #3407

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Conversation

albertvillanova
Copy link
Member

When inferring the module for datasets without script, set a maximum number of iterations over data files.

This PR fixes the issue of taking too long when hundred of data files present.

Please, feel free to agree on both numbers:

# Datasets without script
DATA_FILES_MAX_NUMBER = 10
ARCHIVED_DATA_FILES_MAX_NUMBER = 5

Fix #3404.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thank you ! This will makes the loading of some datasets much much faster.

Some minor comments:

src/datasets/config.py Outdated Show resolved Hide resolved
src/datasets/load.py Outdated Show resolved Hide resolved
src/datasets/load.py Outdated Show resolved Hide resolved
@lhoestq
Copy link
Member

lhoestq commented Dec 14, 2021

Cool thanks :) Feel free to merge if it's all good for you

@albertvillanova albertvillanova merged commit 0d814bd into master Dec 14, 2021
@albertvillanova albertvillanova deleted the fix-3404 branch December 14, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize ZIP format inference
2 participants