Fix str(Path(...)) conversion in streaming on Linux
#3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Thanks for fixing the issue.
I agree this allows working in streaming mode "beans" and "cats_vs_dogs" by fixing a previous malformed path, but as you told me, the source cause of the bug is str(Path()) in streaming mode.
Maybe we should eventually fix the source cause as well.
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Dec 22, 2021
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Dec 22, 2021
mattstern31
added a commit
to mattstern31/datasets-server-storage-admin
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
str(Path(...))conversion in streaming on Linux. This should fix the streaming of thebeansandcats_vs_dogsdatasets.