Add gzip for to_json
#3492
Add gzip for to_json
#3492
Conversation
| import gzip | ||
|
|
||
|
|
||
| class IOHandler: |
There was a problem hiding this comment.
Just a naming suggestion, feel free to ignore if IOHandler sounds better to you
| class IOHandler: | |
| class open_compressed: |
There was a problem hiding this comment.
I also think this could simply be a function that returns the output of open or gzip.open, what do you think ?
There was a problem hiding this comment.
Not sure about this but I think we'll need to close file too after writing which we aren't doing in json.py hence __exit__ thing in context manager
There was a problem hiding this comment.
IOHandler is not just opening compressed files but uncompressed as well :p
There was a problem hiding this comment.
Thanks @bhavitvyamalik!!! :)
Yes, indeed one of the advantages of handling directly the compression parameter ourselves, is that we can use it for other formats, like CSV or text (and maybe other future supported formats).
(Partially) closes #3480. I have added
gzipcompression forto_json. I realised we can run into this compression problem withto_csvas well.IOHandlercan be used forto_csvtoo. Please let me know if any changes are required.