Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of pib dataset and make it streamable #3496

Merged
merged 9 commits into from
Dec 29, 2021
Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Dec 28, 2021

This PR:

  • Updates version of pib dataset: from 0.0.0 to 1.3.0
  • Makes the dataset streamable

Fix #3491.

CC: @severo

@albertvillanova albertvillanova merged commit f7323d8 into master Dec 29, 2021
@albertvillanova albertvillanova deleted the fix-3491 branch December 29, 2021 08:42
@severo
Copy link
Collaborator

severo commented Dec 29, 2021

It seems like there is still an error: Message: 'TarContainedFile' object has no attribute 'readable'

https://huggingface.co/datasets/pib/viewer

@albertvillanova
Copy link
Member Author

@severo I was wondering about that...

It works fine when I run it in streaming mode in my terminal:

In [3]: from datasets import load_dataset; ds = load_dataset("pib", "gu-pa", split="train", streaming=True); item = next(iter(ds))

In [4]: item
Out[4]: 
{'translation': {'gu': 'એવો નિર્ણય લેવાયો હતો કે ખંતપૂર્વકની કામગીરી હાથ ધરવા, કાયદેસર અને ટેકનિકલ મૂલ્યાંકન કરવા, વેન્ચર કેપિટલ ઇન્વેસ્ટમેન્ટ સમિતિની બેઠક યોજવા વગેરે એઆઇએફને કરવામાં આવેલ પ્રતિબદ્ધતાના 0.50 ટકા સુધી અને બાકીની રકમ એફએફએસને પૂર્ણ કરવામાં આવશે.',
  'pa': 'ਇਹ ਵੀ ਫੈਸਲਾ ਕੀਤਾ ਗਿਆ ਕਿ ਐੱਫਆਈਆਈ ਅਤੇ ਬਕਾਏ ਲਈ ਕੀਤੀਆਂ ਗਈਆਂ ਵਚਨਬੱਧਤਾਵਾਂ ਦੇ 0.50 % ਦੀ ਸੀਮਾ ਤੱਕ ਐੱਫਈਐੱਸ ਨੂੰ ਮਿਲਿਆ ਜਾਏਗਾ, ਇਸ ਨਾਲ ਉੱਦਮ ਪੂੰਜੀ ਨਿਵੇਸ਼ ਕਮੇਟੀ ਦੀ ਬੈਠਕ ਦਾ ਆਯੋਜਨ ਉਚਿਤ ਸਾਵਧਾਨੀ, ਕਾਨੂੰਨੀ ਅਤੇ ਤਕਨੀਕੀ ਮੁੱਲਾਂਕਣ ਲਈ ਸੰਚਾਲਨ ਖਰਚ ਆਦਿ ਦੀ ਪੂਰਤੀ ਹੋਵੇਗੀ।'}}

@severo
Copy link
Collaborator

severo commented Jan 3, 2022

OK, it works now!

Capture d’écran 2022-01-03 à 15 41 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of pib dataset
2 participants