Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more information in the README about contributors of the Arabic Speech Corpus #4701

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

nawarhalabi
Copy link
Contributor

Added more information in the README about contributors and encouraged reading the thesis for more infos

Added more contributors and encouraged referring to the PhD thesis by linking to the citation for more information.
Fixed issue with citation references in README
@nawarhalabi nawarhalabi changed the title Added more information in the README about contributors Added more information in the README about contributors of the Arabic Speech Corpus Jul 19, 2022
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@@ -123,31 +123,31 @@ An example from the dataset is:

### Curation Rationale

[Needs More Information]
Please refer to [PhD thesis](#Citation-Information).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to summarize a bit the paper into this section if possible ? And then redirect people who want more details to the paper ? I think it would make it more practical for everyone, what do you think ?

(and same for the other sections)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I updated the readme based on this suggestion.

Added more details on the curation process
Updated annotation section in readme with some summaries
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks !

@lhoestq lhoestq merged commit 70a08cd into huggingface:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants