Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the mlqa dataset card #4809

Merged

Conversation

el2e10
Copy link
Contributor

@el2e10 el2e10 commented Aug 9, 2022

I fixed the issue #4808

Details of PR:

  • Added languages included in the dataset.
  • Added task id and task category.
  • Updated the citation information.

Fix #4808.

@el2e10 el2e10 changed the title Added more details to dataset card of mlqa dataset Added more details to dataset card of mlqa dataset closes #4808 Aug 9, 2022
@el2e10 el2e10 changed the title Added more details to dataset card of mlqa dataset closes #4808 Added more details to dataset card of mlqa dataset Aug 9, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 9, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @eldhoittangeorge.

The CI error message: https://github.com/huggingface/datasets/runs/7743526624?check_suite_focus=true

E           ValueError: The following issues have been found in the dataset cards:
E           YAML tags:
E           __init__() missing 5 required positional arguments: 'annotations_creators', 'language_creators', 'license', 'size_categories', and 'source_datasets'

@el2e10
Copy link
Contributor Author

el2e10 commented Aug 9, 2022

Thanks for your contribution, @eldhoittangeorge.

The CI error message: https://github.com/huggingface/datasets/runs/7743526624?check_suite_focus=true

E           ValueError: The following issues have been found in the dataset cards:
E           YAML tags:
E           __init__() missing 5 required positional arguments: 'annotations_creators', 'language_creators', 'license', 'size_categories', and 'source_datasets'

I will fix the CI error.

@albertvillanova
Copy link
Member

@eldhoittangeorge, thanks again for all the fixes. Just a minor one before we can merge this PR: https://github.com/huggingface/datasets/runs/7744885754?check_suite_focus=true

E           YAML tags:
E           Could not validate the metadata, found the following errors:
E           * field 'language_creators':
E           	['unknown'] are not registered tags for 'language_creators', reference at https://github.com/huggingface/datasets/tree/main/src/datasets/utils/resources/creators.json

Changed language creators tag in dataset card of mlqa dataset to crowdsourced.
@el2e10
Copy link
Contributor Author

el2e10 commented Aug 9, 2022

Thanks, I updated the file.
A small suggestion can you mention this link https://github.com/huggingface/datasets/tree/main/src/datasets/utils/resources/ in the contribution page. So that others will know the acceptable values for the tags.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. In our docs Create a dataset card, we suggest using the Datasets Tagging application: https://huggingface.co/spaces/huggingface/datasets-tagging

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the completion of the dataset card.

@albertvillanova albertvillanova changed the title Added more details to dataset card of mlqa dataset Complete the mlqa dataset card Aug 9, 2022
@albertvillanova albertvillanova merged commit 8a9b3cb into huggingface:main Aug 9, 2022
@el2e10 el2e10 deleted the mlqa-dataset-card-info-update branch August 9, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more information to the dataset card of mlqa dataset
3 participants