Added names of less-studied languages #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
requested changes
Aug 24, 2022
There was a problem hiding this comment.
Thanks for the addition, @BenjaminGalliot.
Just a suggested fix below.
BenjaminGalliot
force-pushed
the
patch-1
branch
from
c130481
to
0b1128a
Compare
Added names of less studied languages (with their Glottolog codes) for existing datasets: Yongning Na (yong1288) and Japhug (japh1234).
BenjaminGalliot
force-pushed
the
patch-1
branch
from
0b1128a
to
747376b
Compare
albertvillanova
requested changes
Aug 24, 2022
There was a problem hiding this comment.
As pointed out in my comment below, currently we are using IANA language codes, not Glottolog codes.
Also note that in each dataset card, besides the language tag (validated against this file languages.json), users can use other tags to give further details about the language:
language_bcp47: to list BCP47 language tags, plus any of the allowed suffixes (script, region, variant,...)language_details: to give further details
|
OK, I removed Glottolog codes and only added ISO 639-3 ones. The former are for the moment in corpus card description, language details, and in subcorpora names. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added names of less-studied languages (nru – Narua and jya – Japhug) for existing datasets.