Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode mp3 with librosa if torchaudio is > 0.12 as a temporary workaround #4923

Merged
merged 38 commits into from
Sep 20, 2022
Merged

decode mp3 with librosa if torchaudio is > 0.12 as a temporary workaround #4923

merged 38 commits into from
Sep 20, 2022

Commits on Aug 31, 2022

  1. decode mp3 with librosa if torchaudio is > 0.12 (ideally version of f… 

    …fmpeg should be checked too)
    @polinaeterna
    polinaeterna committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    37d9eb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. add flake8 ignore for unused imports

    @polinaeterna
    polinaeterna committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    48991d4 View commit details
    Browse the repository at this point in the history

  2. improve error mesasage

    @polinaeterna
    polinaeterna committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4114bd5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'huggingface:main' into workaround-torchaudio-0.12

    @polinaeterna
    polinaeterna authored Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e924ca1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'huggingface:main' into workaround-torchaudio-0.12

    @polinaeterna
    polinaeterna authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2e12525 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge branch 'huggingface:main' into workaround-torchaudio-0.12

    @polinaeterna
    polinaeterna authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f7dbaa8 View commit details
    Browse the repository at this point in the history

  2. decode mp3 with torchaudio>=0.12 if it works (instead of librosa)

    @polinaeterna
    polinaeterna committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    bd7a1ef View commit details
    Browse the repository at this point in the history

  3. fix last commit

    @polinaeterna
    polinaeterna committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f7afaff View commit details
    Browse the repository at this point in the history

  4. fix warnings

    @polinaeterna
    polinaeterna committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    4a9da10 View commit details
    Browse the repository at this point in the history

  5. use datasets logging instead of standard

    @polinaeterna
    polinaeterna committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    7fca41f View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. fix incorrect marks for mp3 tests (require torchaudio, not sndfile)

    @polinaeterna
    polinaeterna committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    1305be2 View commit details
    Browse the repository at this point in the history

  2. add tests for latest torchaudio + separate stage in CI for it (first … 

    …try)
    @polinaeterna
    polinaeterna committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    05d400a View commit details
    Browse the repository at this point in the history

  3. get back unintantionally removed require_sox for mp3 tests

    @polinaeterna
    polinaeterna committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    6e82a88 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. install ffmpeg in CI env to test torchaudio

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    883b6f5 View commit details
    Browse the repository at this point in the history

  2. test CI again...

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    d5f06ed View commit details
    Browse the repository at this point in the history

  3. fix pip uninstall - add missing -y param

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4fbaeb6 View commit details
    Browse the repository at this point in the history

  4. install ffmpeg only on ubuntu

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2ee379f View commit details
    Browse the repository at this point in the history

  5. try to compile old version of ffmpeg to test librosa mp3 loading

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    400d8f1 View commit details
    Browse the repository at this point in the history

  6. fix ci.yml

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    942d396 View commit details
    Browse the repository at this point in the history

  7. add some option to configure of old ffmpeg (i have no idea what it me… 

    …ans)
    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    b0f8bb7 View commit details
    Browse the repository at this point in the history

  8. use mock to emulate torchaudio fail, add tests for librosa (not all o… 

    …f them)
    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    6d4d9a2 View commit details
    Browse the repository at this point in the history

  9. add missing | in ci run

    @polinaeterna
    polinaeterna committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3f3cb53 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Merge branch 'huggingface:main' into workaround-torchaudio-0.12

    @polinaeterna
    polinaeterna authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0748cc4 View commit details
    Browse the repository at this point in the history

  2. try to skip test if ffmpeg not installed

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    1cae272 View commit details
    Browse the repository at this point in the history

  3. remove ffmpeg version checking on windows ci

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    4665dcf View commit details
    Browse the repository at this point in the history

  4. test torchaudio_latest only on ubuntu

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    7960700 View commit details
    Browse the repository at this point in the history

  5. refactor test for latest torchaudio 

    check if it works and fails in a single test
    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    5f0efed View commit details
    Browse the repository at this point in the history

  6. try/except decoding with librosa for file-like objects

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    bfe1be7 View commit details
    Browse the repository at this point in the history

  7. more tests for latest torchaudio, should be comlpete set now

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    9dd632d View commit details
    Browse the repository at this point in the history

  8. remove unused decorator for ffmpeg checking

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    852176c View commit details
    Browse the repository at this point in the history

  9. refactor ci workflow (first install, then test)

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    557a9cb View commit details
    Browse the repository at this point in the history

  10. get back full library testing

    @polinaeterna
    polinaeterna committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    3f63882 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Update tests/utils.py 

    Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
    @polinaeterna @lhoestq
    polinaeterna and lhoestq authored Sep 20, 2022
    Configuration menu
    Copy the full SHA
    a0672cc View commit details
    Browse the repository at this point in the history

  2. replace logging with warnings

    @polinaeterna
    polinaeterna committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    420f63d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'workaround-torchaudio-0.12' of github.com:polinaeterna/… 

    …datasets into workaround-torchaudio-0.12
    @polinaeterna
    polinaeterna committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    b4a8793 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'huggingface:main' into workaround-torchaudio-0.12

    @polinaeterna
    polinaeterna authored Sep 20, 2022
    Configuration menu
    Copy the full SHA
    c016395 View commit details
    Browse the repository at this point in the history

  5. fix tests: catch warnings with a pytest context manager

    @polinaeterna
    polinaeterna committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ebf77d7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'workaround-torchaudio-0.12' of github.com:polinaeterna/… 

    …datasets into workaround-torchaudio-0.12
    @polinaeterna
    polinaeterna committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ae67712 View commit details
    Browse the repository at this point in the history