-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH->HF] Part 2: Remove all dataset scripts from github #4974
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good: this way all datasets are completely aligned.
Just one thought: HEHE, I would say that it is at least ironic that a library called datasets
deletes all the datasets but nevertheless keeps the metrics (which indeed were moved to other library)... 🤣
So this means metrics will be deleted from this repo in favor of the "evaluate" library? Maybe you guys could just redirect metrics to that library. |
We are deprecating the metrics in We'll keep the current metrics as they are for now, but they'll be completely removed at one point |
I guess this is ready to merge ? It should break nothing except one rare case: If someone is using an old version of e.g. if someone uses "imagenet-1k" with a version of But if they delete their cache, the workaround is... 🥁 update |
Let's merge this on monday if we can, to make sure contributors who wanted to merge their dataset PRs here could do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All pending PRs have been either merged or closed.
You can now remove all dataset scripts from GitHub.
Alright, merging ! |
Now that all the datasets live on the Hub we can remove the /datasets directory that contains all the dataset scripts of this repository