Prefer split patterns from directories over split patterns from filenames #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinaeterna
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
reviewed
Sep 16, 2022
src/datasets/data_files.py
Outdated
| @@ -73,10 +73,10 @@ class Url(str): | |||
| Split.TRAIN: ["**"], | |||
| } | |||
|
|
|||
| ALL_SPLIT_PATTERNS = [SPLIT_PATTERN_SHARDED] | |||
| ALL_SPLIT_PATTERNS = [SPLIT_PATTERN_SHARDED] # TODO: should this be changed? | |||
There was a problem hiding this comment.
I think it's fine this way. This corresponds to the patterns that contain custom split names (other than train/dev/test)
This was
linked to
issues
Sep 23, 2022
|
Can we merge this one since the issue this PR fixes was reported for the second time? I also think we don't need a test for this simple change. |
|
@mariosasko sure! could you please approve it? |
polinaeterna
changed the title
mariosasko
approved these changes
Sep 28, 2022
|
Hi there @polinaeterna @mariosasko! I have installed 5.2.3.dev0, which should have this fix. Unfortunately, I am still getting the error: Any help would be greatly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4895