Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kwargs to Dataset.from_generator #5049

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add kwargs to Dataset.from_generator #5049

merged 1 commit into from
Oct 3, 2022

Conversation

mariosasko
Copy link
Collaborator

Add the kwargs param to from_generator to align it with the rest of the from_ methods (this param allows passing custom writer_batch_size for instance).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 30, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lhoestq
lhoestq approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks !

@mariosasko mariosasko merged commit a8893e6 into main Oct 3, 2022
@mariosasko mariosasko deleted the from_generator-kwargs branch October 3, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariosasko @HuggingFaceDocBuilderDev @lhoestq