Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI hfh token warning #5062

Merged

Conversation

albertvillanova
Copy link
Member

In our CI, we get warnings from hfh about using deprecated token: https://github.com/huggingface/datasets/actions/runs/3174626525/jobs/5171672431

tests/test_upstream_hub.py::TestPushToHub::test_push_dataset_dict_to_hub_private
tests/test_upstream_hub.py::TestPushToHub::test_push_dataset_dict_to_hub
tests/test_upstream_hub.py::TestPushToHub::test_push_dataset_dict_to_hub_multiple_files
tests/test_upstream_hub.py::TestPushToHub::test_push_dataset_dict_to_hub_multiple_files_with_max_shard_size
tests/test_upstream_hub.py::TestPushToHub::test_push_dataset_dict_to_hub_overwrite_files
  C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\site-packages\huggingface_hub\utils\_deprecation.py:97: FutureWarning: Deprecated argument(s) used in 'dataset_info': token. Will not be supported from version '0.12'.
    warnings.warn(message, FutureWarning)

This PR fixes the tests in TestPushToHub so that we fix these warnings.

Continuation of:

CC: @lhoestq

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 4, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova changed the title Fix hfh token warning Fix CI hfh token warning Oct 4, 2022
@albertvillanova albertvillanova merged commit fa05c02 into huggingface:main Oct 4, 2022
@albertvillanova albertvillanova deleted the fix-hfh-token-warning branch October 4, 2022 08:42
@lhoestq
Copy link
Member

lhoestq commented Oct 4, 2022

good catch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants