Align signature of create/delete_repo with latest hfh #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
reviewed
Oct 4, 2022
src/datasets/utils/_hf_hub_fixes.py
Outdated
| return hf_api.create_repo( | ||
| name=name, | ||
| organization=organization, | ||
| organization=organization or None, |
There was a problem hiding this comment.
Suggested change
| organization=organization or None, | |
| organization=organization, |
src/datasets/utils/_hf_hub_fixes.py
Outdated
| @@ -88,15 +83,16 @@ def delete_repo( | |||
| `str`: URL to the newly created repo. | |||
| """ | |||
| if version.parse(huggingface_hub.__version__) < version.parse("0.5.0"): | |||
| name, *organization = repo_id.split("/") | |||
There was a problem hiding this comment.
same here
Suggested change
| name, *organization = repo_id.split("/") | |
| organization, name = repo_id.split("/") if "/" in repo_id else None, repo_id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the signature of
create_repo/delete_repowith the current one in hfh, by removing deprecatednameandorganization, and usingrepo_idinstead.Related to:
CC: @lhoestq