Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update exception throw from OSError to EnvironmentError in `push… #5076

Merged
merged 1 commit into from
Oct 7, 2022
Merged

fix: update exception throw from OSError to EnvironmentError in `push… #5076

merged 1 commit into from
Oct 7, 2022

Conversation

rahulXs
Copy link
Contributor

@rahulXs rahulXs commented Oct 5, 2022 •
edited
Loading

Status:
Ready for review

Description of Changes:
Fixes #5075

Changes proposed in this pull request:

  • Throw EnvironmentError instead of OSError in push_to_hub when the Hub token is not present.

@rahulXs rahulXs mentioned this pull request Oct 5, 2022
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 5, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

mariosasko
mariosasko approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mariosasko mariosasko merged commit e0dd33c into huggingface:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosasko mariosasko mariosasko approved these changes

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw EnvironmentError when token is not present
4 participants
@rahulXs @HuggingFaceDocBuilderDev @lhoestq @mariosasko