Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding keep in memory #5082

Merged
merged 4 commits into from
Oct 7, 2022
Merged

adding keep in memory #5082

merged 4 commits into from
Oct 7, 2022

Conversation

Mustapha-AJEGHRIR
Copy link
Contributor

Fixing #514 .

Hello @mariosasko 👋, I have implemented what you have recommanded to fix the keep in memory problem for shuffle on the issue #514 .

@Mustapha-AJEGHRIR Mustapha-AJEGHRIR mentioned this pull request Oct 6, 2022
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

mariosasko
mariosasko reviewed Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We also need a test with shuffle(keep_in_memory=True) for this fix. Let me know if you need help with that.

src/datasets/arrow_dataset.py Outdated Show resolved Hide resolved
Mustapha-AJEGHRIR and others added 3 commits October 6, 2022 14:58
@Mustapha-AJEGHRIR @mariosasko
Update src/datasets/arrow_dataset.py
2d37e1f 
Co-authored-by: Mario Šaško <mariosasko777@gmail.com>
adding keep in memory test + remove 'compatible with temp_seed' insid…
fb79fc0 
…e the dset_shuffled scope
make style
c96d72d
@Mustapha-AJEGHRIR
Copy link
Contributor Author

Hi @mariosasko , I have added a test for the keep_in_memory version. I have also removed the Compatible with temp_seed part in the scope of dset_shuffled, please verify if that makes sense.

mariosasko
mariosasko approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now!

lhoestq
lhoestq approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@mariosasko mariosasko merged commit 655483d into huggingface:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosasko mariosasko mariosasko approved these changes

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mustapha-AJEGHRIR @HuggingFaceDocBuilderDev @lhoestq @mariosasko