Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iter_files deterministic #5149

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

albertvillanova
Copy link
Member

Fix #5145.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! LGTM :)

@albertvillanova albertvillanova merged commit 8aaf0b6 into huggingface:main Oct 27, 2022
@albertvillanova albertvillanova deleted the fix-5145 branch October 27, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset order is not deterministic with ZIP archives and iter_files
3 participants