Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add notebook links to img cls and obj det. #5187

Merged
merged 3 commits into from
Nov 3, 2022
Merged

chore: add notebook links to img cls and obj det. #5187

merged 3 commits into from
Nov 3, 2022

Conversation

sayakpaul
Copy link
Member

Closes #5182

sayakpaul
sayakpaul commented Nov 2, 2022
View reviewed changes
docs/source/object_detection.mdx
Comment on lines +157 to +159
To learn how to leverage parts of 🤗 datasets end-to-end for training an object detection model, refer to
[this notebook](https://nbviewer.org/github/NielsRogge/Transformers-Tutorials/blob/master/YOLOS/Fine_tuning_YOLOS_for_object_detection_on_custom_dataset_%28balloon%29.ipynb).

Copy link
Member Author

@sayakpaul sayakpaul Nov 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsRogge is there a plan to leverage more parts of datasets in this notebook? I have gone through the notebook and it felt like it was necessary to leverage torchvision in some parts to get the data pipeline ready.

Let me know.

@sayakpaul sayakpaul self-assigned this Nov 2, 2022
@sayakpaul sayakpaul added the enhancement New feature or request label Nov 2, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

nateraw
nateraw approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer both be GitHub links, but that's just my opinion. Other than that, LGTM

docs/source/object_detection.mdx Show resolved Hide resolved
@sayakpaul
Copy link
Member Author

@nateraw I guess the failing test is unrelated.

@nateraw
Copy link
Contributor

nateraw commented Nov 2, 2022

@sayakpaul Yea failures are unrelated.

@sayakpaul
Copy link
Member Author

Alright. Will wait for @osanseviero's take and then merge.

osanseviero
osanseviero approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that could help here, but otherwise LGTM!

docs/source/object_detection.mdx Show resolved Hide resolved
docs/source/image_classification.mdx Outdated Show resolved Hide resolved
docs/source/image_classification.mdx Outdated Show resolved Hide resolved
@osanseviero
Copy link
Contributor

FYI @stevhliu

stevhliu
stevhliu approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for connecting all these resources!

docs/source/image_classification.mdx Outdated Show resolved Hide resolved
docs/source/image_classification.mdx Outdated Show resolved Hide resolved
sayakpaul and others added 2 commits November 3, 2022 06:54
@sayakpaul @stevhliu
Apply suggestions from code review
1006f59 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@sayakpaul
chore: PR feedback.
f413adf
@sayakpaul
Copy link
Member Author

@osanseviero @stevhliu @nateraw thank you for your comments. Acted on them.

nateraw
nateraw approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sayakpaul
Copy link
Member Author

Thanks! Can I merge? Or should we wait for approvals from the others?

@nateraw
Copy link
Contributor

nateraw commented Nov 3, 2022

Since @stevhliu approved as well, I think you're good to go

@sayakpaul
Copy link
Member Author

Alright!

Merging as a Member for the first time 🫀

@sayakpaul sayakpaul merged commit 2cfb5d5 into huggingface:main Nov 3, 2022
@sayakpaul sayakpaul deleted the add/notebook-links branch November 3, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateraw nateraw nateraw approved these changes

@stevhliu stevhliu Awaiting requested review from stevhliu

@osanseviero osanseviero Awaiting requested review from osanseviero

Assignees

@sayakpaul sayakpaul

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notebook / other resource links to the task-specific data loading guides
5 participants
@sayakpaul @HuggingFaceDocBuilderDev @nateraw @osanseviero @stevhliu