Save file name in embed_storage #5285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -229,7 +228,10 @@ def path_to_bytes(path): | |||
| ], | |||
| type=pa.binary(), | |||
| ) | |||
| path_array = pa.array([None] * len(storage), type=pa.string()) if drop_paths else storage.field("path") | |||
| path_array = pa.array( | |||
| [os.path.basename(path) if path is not None else None for path in storage.field("path").to_pylist()], | |||
There was a problem hiding this comment.
I would suggest to store full paths to avoid ambiguities + metadata information like classes might be reflected in directories names.
There was a problem hiding this comment.
It may store personal information about the user though, not a big fan
There was a problem hiding this comment.
okay, agree, users can include full paths in a separate field if needed
|
I updated the tests, met le know if it sounds good to you now :) |
polinaeterna
approved these changes
Nov 23, 2022
| @@ -229,7 +228,10 @@ def path_to_bytes(path): | |||
| ], | |||
| type=pa.binary(), | |||
| ) | |||
| path_array = pa.array([None] * len(storage), type=pa.string()) if drop_paths else storage.field("path") | |||
| path_array = pa.array( | |||
| [os.path.basename(path) if path is not None else None for path in storage.field("path").to_pylist()], | |||
There was a problem hiding this comment.
okay, agree, users can include full paths in a separate field if needed
Co-authored-by: Polina Kazakova <polina@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the file name is useful in case we need to check the extension of the file (e.g. mp3), or in general in case it includes some metadata information (track id, image id etc.)
Related to #5276