Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xjoin for Windows pathnames #5297

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

albertvillanova
Copy link
Member

This PR fixes a bug in xjoin function with Windows pathnames.

Fix #5296.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 25, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@albertvillanova albertvillanova merged commit 225362a into huggingface:main Nov 29, 2022
@albertvillanova albertvillanova deleted the fix-xjoin-windows branch November 29, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in xjoin with Windows pathnames
3 participants