Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use_auth_token docstring and deprecate use_auth_token in download_and_prepare #5302

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

mariosasko
Copy link
Collaborator

Clarify in the docstrings what happens when use_auth_token is None and deprecate the use_auth_token param in download_and_prepare.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 25, 2022

The documentation is not available anymore as the PR was closed or merged.

@mariosasko mariosasko changed the title Improve use_auth_token docstring and deprecate use_auth_token download_and_prepare Improve use_auth_token docstring and deprecate use_auth_token in download_and_prepare Nov 28, 2022
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

src/datasets/builder.py Show resolved Hide resolved
src/datasets/builder.py Outdated Show resolved Hide resolved
mariosasko and others added 3 commits December 9, 2022 13:42
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants