-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xPath for Windows pathnames #5310
Merged
albertvillanova
merged 12 commits into
huggingface:main
from
albertvillanova:refactor-as-posix
Nov 30, 2022
Merged
Support xPath for Windows pathnames #5310
albertvillanova
merged 12 commits into
huggingface:main
from
albertvillanova:refactor-as-posix
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is not available anymore as the PR was closed or merged. |
albertvillanova
changed the title
Support streaming datasets with pathlib.Path.as_posix
Support xPath for Windows pathnames
Nov 29, 2022
lhoestq
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks ! Maybe just one test:
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
lhoestq
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a string representation of
xPath
, which is valid for local paths (also windows) and remote URLs.Additionally, some
os.path
methods are fixed for remote URLs on Windows machines.Now, on Windows machines: